Skip to content

Remove always-false check in CLI #10723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

Remove always-false check in CLI #10723

merged 1 commit into from
Feb 28, 2023

Conversation

nielsdos
Copy link
Member

This is the case c == 'i', so c == '?' is always false, hence the result is always 0.

@nielsdos
Remove always-false check in CLI
7f1da03 
This is the case c == 'i', so c == '?' is always false, hence the result
is always 0.
@iluuu1994 iluuu1994 merged commit f247e48 into php:master Feb 28, 2023
@iluuu1994
Copy link
Member

Thank you @nielsdos 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
SAPI: cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @iluuu1994